Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

tf.image.transform no-shader implementation #1641

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

piercus
Copy link
Contributor

@piercus piercus commented Mar 21, 2019

This PR aims to fix tensorflow/tfjs#1426 and replaces #1637

After trying to implement specific webgl/cpu shaders in #1637 i realized ImageProjectiveTransform is not available in the ops list of C API.

Considering this, I've implemented it in a no-shader way, using tf.gatherND as the cornerstone of the implementation.

This new version won't need to maintain multiple shaders but may be a little bit slower (i haven't fully tested the performance yet)

Since the implementation takes 300 lines, i have put it into a separated file required in image_ops.ts.

Please share your feedbacks and suggestions :-)


This change is Reviewable

@piercus piercus changed the title tf.image.transform pure-linear algebra implementation tf.image.transform no-shader implementation Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant