This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
webgpu: conv2d_mm: Fix dispatch dimensions #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
force-pushed
the
fix-conv-mm
branch
2 times, most recently
from
091f2af
to
11d984f
Compare
kainino0x
commented
May 7, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained
src/backends/webgpu/src/kernels/conv2d_mm_webgpu.ts, line 40 at r2 (raw file):
constructor(convInfo: Conv2DInfo, workPerThread: number) { this.outputShape = convInfo.outShape;
I think you were talking about moving the computeDispatch out of the individual ops.
Does the exported outputShape need be matMulOutShape below?
Will that break the actual tensor output shape? (Do we need both an outputShape and a shapeForDispatch?) I'd be in favor of just keeping the computeDispatch in the op.
And some other minor tweaks.
axinging
added a commit
to qjia7/tfjs-webgl2compute
that referenced
this pull request
Jul 9, 2019
This CL gurantees below test case run correctly. But leads to significant performance regression on some case. We will fix this later. Merge from this: tensorflow/tfjs-core#1745 Test case is from: https://github.com/tensorflow/tfjs-core/pull/1745/files#diff-15289bfca30229483003cbaea418596aR191
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some other minor tweaks.
To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.
This change is