This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Fix unit tests to ensure that test registrations happen before tests. #1788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test registries would happen as a function of imports. This doesn't ensure that unconstrained tests run after tests get registered.
This PR creates a
setup_test.ts
file like we do in WebGPU which imports the registries and then parses the karma flags. This ensures the expected order.This PR also adds --testEnv as a command line flag instead of --backend.
This change is