This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Add integration_test/tfjs2keras; Fix the bugs uncovered by the test #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caisq
force-pushed
the
node2python
branch
8 times, most recently
from
631cc01
to
bf68fe3
Compare
This is a node.js-Python integration test. It checks that the models exported from tfjs-layers can be loaded properly by Keras in Python. Fix bugs uncovered by the test - In Activation layers - In RNN layers
caisq
changed the title
caisq
requested review from
dsmilkov,
nsthorat,
bileschi,
davidsoergel and
ericdnielsen
ericdnielsen
approved these changes
May 11, 2018
| } | ||
|
|
||
| // Convolutional neural network (CNN). | ||
| function exportCNNModel(exportPath: string): void { |
There was a problem hiding this comment.
Going to approve the PR as it is, but how hard would it be to evolve the system to use either directories in tfjs-examples or tfjs-models as the source of models rather than hard-coding them here.
There was a problem hiding this comment.
Good question. If we were to use models from tfjs-examples or tfjs-models, the test should probably live there instead in tfjs-layers. Another difficulty is the fact that examples are browser oriented (not sure about models), but the test here relies on node.js. I'll explore that later.
…and non-Travis environments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a node.js-Python integration test. It checks that the models
exported from tfjs-layers can be loaded properly by Keras in Python.
Fix bugs uncovered by the test
Towards: tensorflow/tfjs#13
This change is