Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Let UpSampling2D Layer accept undetermined image sizes #262

Merged
merged 4 commits into from
Jul 9, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Jul 8, 2018

Fixes: tensorflow/tfjs#403


This change is Reviewable

@caisq caisq requested a review from nsthorat July 8, 2018 16:10
@caisq
Copy link
Contributor Author

caisq commented Jul 8, 2018

cc @oeway

@caisq caisq requested a review from bileschi July 9, 2018 03:35
Copy link
Contributor

@bileschi bileschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained


src/layers/convolutional_test.ts, line 1114 at r2 (raw file):

'undetermined image size'

Possibly a better test name here is in order. Something like: Layer is reusable for multiple sizes. -- Concrete tensors can not have undetermined size, and the first half of this test is identical to 'channelsLast' above.

Copy link
Contributor

@bileschi bileschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Copy link
Contributor Author

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained


src/layers/convolutional_test.ts, line 1114 at r2 (raw file):

Previously, bileschi (Stanley Bileschi) wrote…
'undetermined image size'

Possibly a better test name here is in order. Something like: Layer is reusable for multiple sizes. -- Concrete tensors can not have undetermined size, and the first half of this test is identical to 'channelsLast' above.

Thanks. Renamed the test to "varying input image sizes"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants