Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Refactor topology.ts into smaller source files #263

Merged
merged 8 commits into from
Jul 11, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Jul 10, 2018

DEV

  • Split Container and related classes, interfaces and functions into container.ts.
  • Split InputLayer and related classes, interfaces and functions into input_layer.ts.

Towards tensorflow/tfjs#490


This change is Reviewable

Copy link
Member

@davidsoergel davidsoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) Aside: now that we're continuing down the road of abandoning parity with the Keras file organization, there are various other refactorings like this that would improve matters (imho) if anyone has the time.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained


src/engine/container.ts, line 724 at r1 (raw file):

 
 

nit: extra newlines

Copy link
Contributor Author

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

I forgot mention that this change actually improves parity with keras' source file structure, because keras underwent similar refactoring recently. But in general, I support refactoring to improve code structure.

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained


src/engine/container.ts, line 724 at r1 (raw file):

Previously, davidsoergel (David Soergel) wrote…
 
 

nit: extra newlines

Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants