Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Remove tslint:disable:max-line-length in tfjs-layers #276

Merged
merged 7 commits into from Aug 3, 2018
Merged

Remove tslint:disable:max-line-length in tfjs-layers #276

merged 7 commits into from Aug 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2018

・delete // tslint:disable:max-line-length
・ modify tslint.json (add ignore-pattern to max-line-length)
DEV


This change is Reviewable

delete // tslint:disable:max-line-length
hiyashichuka added 2 commits August 1, 2018 07:52
change " tslint.json of layers" to " tslint.json of HEAD in core".
Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 55 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @HiyashiChuka)


src/activations_test.ts, line 19 at r1 (raw file):

import {describeMathCPUAndGPU, expectNoLeakedTensors, expectTensorsClose} from './utils/test_utils';

// tslint:enable

Can you also remove these? There are some that are explicitly enable "max-line-length" as well as just generally "enable"

Thanks so much for this contribution, this is wonderful. This, I think is the final piece :)

@ghost
Copy link
Author

ghost commented Aug 1, 2018

@nsthorat
Thank you for your comment!
I removed // tslint:enable.

Copy link
Contributor

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @HiyashiChuka)


tslint.json, line 61 at r2 (raw file):

}

Please restore the newline character at the end of this file.

@ghost
Copy link
Author

ghost commented Aug 1, 2018

@caisq
Thank you for your comment!
I apologize for my carelessness.  I revised it.

Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @HiyashiChuka)


src/base_callbacks.ts, line 19 at r3 (raw file):

import {Logs, resolveScalarsInLogs, UnresolvedLogs} from './logs';
import * as generic_utils from './utils/generic_utils';
// tslint:enable:max-line-length

apologies for not being clear, this should also be removed (and also in all the other files)

@ghost
Copy link
Author

ghost commented Aug 2, 2018

@nsthorat
Thank you for your comment!
I removed // tslint:enable:max-line-length

@nsthorat
Copy link

nsthorat commented Aug 3, 2018

Wonderful, thank you for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants