-
Notifications
You must be signed in to change notification settings - Fork 95
Remove tslint:disable:max-line-length in tfjs-layers #276
Conversation
delete // tslint:disable:max-line-length
change " tslint.json of layers" to " tslint.json of HEAD in core".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 55 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @HiyashiChuka)
src/activations_test.ts, line 19 at r1 (raw file):
import {describeMathCPUAndGPU, expectNoLeakedTensors, expectTensorsClose} from './utils/test_utils'; // tslint:enable
Can you also remove these? There are some that are explicitly enable "max-line-length" as well as just generally "enable"
Thanks so much for this contribution, this is wonderful. This, I think is the final piece :)
@nsthorat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 approvals obtained (waiting on @HiyashiChuka)
tslint.json, line 61 at r2 (raw file):
}
Please restore the newline character at the end of this file.
@caisq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @HiyashiChuka)
src/base_callbacks.ts, line 19 at r3 (raw file):
import {Logs, resolveScalarsInLogs, UnresolvedLogs} from './logs'; import * as generic_utils from './utils/generic_utils'; // tslint:enable:max-line-length
apologies for not being clear, this should also be removed (and also in all the other files)
@nsthorat |
Wonderful, thank you for the contribution! |
・delete
// tslint:disable:max-line-length
・ modify tslint.json (add ignore-pattern to max-line-length)
DEV
This change is