This repository has been archived by the owner on Oct 17, 2021. It is now read-only.
Add test and guard for circular model weight assignment. #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes tfjs#465 "Manually setting weights for mode" in the case of setting weights to weights the model already owns. Previously the TFJS infrastructure was discarding needed weights.
Adds unit tests covering the behavior (fit model, assign weights to weights the model already owns, check the weights).
For repository owners only:
BUG: fixes tfjs-union#465
This change is