Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Add missing params to Callbacks: samples and batchSize #299

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Add missing params to Callbacks: samples and batchSize #299

merged 1 commit into from
Aug 24, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Aug 24, 2018 •
edited by nsthorat

Towards: tensorflow/tfjs#631

This change is Reviewable

@caisq
Copy link
Contributor Author

caisq commented Aug 24, 2018

Thanks, @ericdnielsen

@caisq caisq merged commit 2244378 into tensorflow:master Aug 24, 2018
@bileschi
Copy link
Contributor

src/engine/training_test.ts, line 1139 at r1 (raw file):

      super({
        onTrainBegin: async () => {
          console.log('this.params:', this.params);

Did you mean to include this console.log statement?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericdnielsen ericdnielsen ericdnielsen approved these changes

@bileschi bileschi Awaiting requested review from bileschi

@nsthorat nsthorat Awaiting requested review from nsthorat

@nkreeger nkreeger Awaiting requested review from nkreeger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@caisq @bileschi @ericdnielsen