Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Improve error message thrown when serializable object is not found #300

Merged
merged 3 commits into from
Aug 25, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Aug 24, 2018

in name-class map

Fixes tensorflow/tfjs#625


This change is Reviewable

Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @caisq, @ericdnielsen, @dsmilkov, and @bileschi)


src/utils/generic_utils.ts, line 178 at r1 (raw file):

            `2. The custom ${printableModuleName} is defined in JavaScript, ` +
            `but is not registered properly with ` +
            `tf.serialization.registerClass().`);

Would be nice to point to the custom layers example: https://github.com/tensorflow/tfjs-examples/tree/master/custom-layer

Copy link
Contributor Author

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @caisq, @ericdnielsen, and @bileschi)


src/utils/generic_utils.ts, line 178 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

Would be nice to point to the custom layers example: https://github.com/tensorflow/tfjs-examples/tree/master/custom-layer

Thanks for the suggestion. I was thinking of the same thing. However, I'd prefer the link to be a tutorial or how-to page on js.tensorflow.org, which looks more permanent and well-organized. We don't have such a page yet, but I'm planning to add one. I added a TODO item here.

@caisq caisq merged commit 25d6703 into tensorflow:master Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants