Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Metrics: Adds recall to the api #323

Merged
merged 3 commits into from
Sep 13, 2018
Merged

Conversation

manrajgrover
Copy link
Contributor

@manrajgrover manrajgrover commented Sep 11, 2018

Description

This PR adds recall to the metrics api


For repository owners only:

Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY

For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md


This change is Reviewable

@caisq caisq self-assigned this Sep 12, 2018
Copy link
Contributor

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewable status: 0 of 1 approvals obtained (waiting on @manrajgrover, @ericdnielsen, and @bileschi)


src/metrics_test.ts, line 248 at r1 (raw file):

const x = tensor2d([[0, 0, 1], [0, 0, 1], [1, 0, 0], [0, 1, 0]]);

I think the edge case for recall is the cases in which there are no 1's in x.

@caisq
Copy link
Contributor

caisq commented Sep 12, 2018

@manrajgrover Heads-up as this PR looks great except the minor testing issue I pointed out in the last comment, I may merge it first and improve the test myself. We are planning a new release soon and I want to include the new metrics in that release.

@ericdnielsen @bileschi please chime in if you have any thoughts.

Copy link
Contributor

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @manrajgrover !!

Reviewable status: 0 of 1 approvals obtained (waiting on @manrajgrover, @ericdnielsen, and @bileschi)

@caisq caisq merged commit bd42154 into tensorflow:master Sep 13, 2018
@manrajgrover manrajgrover deleted the add-recall branch September 13, 2018 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants