Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

LSTM and GRU performance: Replace tf.slice with tf.split #365

Merged
merged 9 commits into from Nov 5, 2018
Merged

LSTM and GRU performance: Replace tf.slice with tf.split #365

merged 9 commits into from Nov 5, 2018

Conversation

caisq
Copy link
Contributor

@caisq caisq commented Nov 4, 2018 •
edited

PERF

Improvement in Benchmarks (Averaging 5-6 repeated runs of the benchmark to reduce noise):

  • GRU predict:
    • 92.7 ms --> 86.4 ms (1.07x)
  • LSTM predict:
    • 72.1 ms --> 68.7 ms (1.05x)
  • Attention predict:
    • 72.9 ms --> 69.6 ms (1.05x)

Relating to tensorflow/tfjs#863

This change is Reviewable

@caisq caisq requested a review from nsthorat November 5, 2018 17:52
@caisq caisq changed the title [WIP] LSTM and GRU performance: Replace tf.slice with tf.split LSTM and GRU performance: Replace tf.slice with tf.split Nov 5, 2018
nsthorat
nsthorat approved these changes Nov 5, 2018
View reviewed changes
Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat)

@caisq
Copy link
Contributor Author

caisq commented Nov 5, 2018

Thanks for the review!

@caisq caisq merged commit e0ff798 into tensorflow:master Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsthorat nsthorat nsthorat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@caisq @nsthorat