Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[speech-commands] require util only when scheme is file:// #655

Closed
wants to merge 8 commits into from
Closed

[speech-commands] require util only when scheme is file:// #655

wants to merge 8 commits into from

Conversation

Dimitris-Toulis
Copy link

@Dimitris-Toulis Dimitris-Toulis commented Apr 19, 2021

Currently speech-commands imports util at top level. This does not work with some bundlers (like Vite) that do not polyfill node built-ins.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@Dimitris-Toulis Dimitris-Toulis changed the title fix(speech-commands): require util only when scheme is file fix(speech-commands): require util only when scheme is file:// Apr 22, 2021
@Dimitris-Toulis Dimitris-Toulis changed the title fix(speech-commands): require util only when scheme is file:// [speech-commands] require util only when scheme is file:// Apr 22, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants