Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Allow more customization of line and scatter plots #22

Merged
merged 4 commits into from
Nov 1, 2018
Merged

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Nov 1, 2018

  • Allow setting custom domains for axes
  • Add zoomToFit option to allow non zero baselines

This change is Reviewable

@tafsiri
Copy link
Contributor Author

tafsiri commented Nov 1, 2018

screen shot 2018-11-01 at 1 42 24 pm

screen shot 2018-11-01 at 1 42 33 pm

@tafsiri tafsiri requested a review from caisq November 1, 2018 19:09
Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @tafsiri and @caisq)


demos/api/index.html, line 257 at r1 (raw file):

      <script class='show-script'>
        {
          const series1 = Array(100).fill(0)

any reason not to use tf.randomNormal? or is this just bc you want to show flexibility

Copy link
Contributor Author

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @caisq)


demos/api/index.html, line 257 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

any reason not to use tf.randomNormal? or is this just bc you want to show flexibility

primarily for simplicity. Also these functions take regular arrays not tensors (so i also don't need any async stuff).

@tafsiri tafsiri merged commit d772f7d into master Nov 1, 2018
@caisq
Copy link

caisq commented Nov 1, 2018

Thanks, @tafsiri ! LGTM.

@tafsiri
Copy link
Contributor Author

tafsiri commented Nov 1, 2018

@caisq no worries, this will bubble up to the higher level functions in future PRs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants