Add accuracy, perClassAccuracy and confusionMatrix calculator helpers #5

tafsiri · 2018-08-28T23:00:33Z

This change is

nsthorat

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @tafsiri and @dsmilkov)

src/util/math.ts, line 142 at r1 (raw file):

 * Computes a confusion matrix from predictions and labels. Each value in
 * labels and predictions should correspond to some output class. It is assumed
 * that these values go from 0 - numClasses.

numClasses - 1?

src/util/math.ts, line 167 at r1 (raw file):

  }

  let numClasses_: number;

optional: you dont need another variable, you could just overwrite the one passed in

src/util/math.ts, line 170 at r1 (raw file):

  if (numClasses == null) {
    numClasses_ = tidy(() => {
      return maximum(labels.max(), predictions.max()).dataSync()[0] + 1;

this assumes that all classes have representation, right? is this what tf does?

src/util/math.ts, line 205 at r1 (raw file):

/**
 * Computes how often predictions matches labels

period

src/util/math.ts, line 227 at r1 (raw file):

 * Computes per class accuracy between prediction and labels. Each value in
 * labels and predictions should correspond to some output class. It is assumed
 * that these values go from 0 - numClasses.

-1

tafsiri

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tafsiri and @dsmilkov)

src/util/math.ts, line 142 at r1 (raw file):