-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of Assert Ops ? #55
Comments
From @pyu10055 on March 21, 2018 20:50 The Assert op is a control flow op which requires run-time eval of the tensor, which will be my goal to support with other control op (merge, switch, ...). |
From @pyu10055 on March 21, 2018 23:46 I notice Assert is usually accompanied by Switch op, does your model only have the Assert op unsupported? If so, do you mind sharing the model, so I can investigate a bit more. Thanks. |
From @pyu10055 on March 31, 2018 18:2 We believe that the Assert op should not exist in the inference graph, we will remove the assert and other debug nodes from the graph during the conversion phase. |
+1 on this issue. It would be extremely painful for me (requiring hundreds of lines of code changes) to manually remove all the assertions from my graph because they are generated by library code (e.g. DeepMind's |
Even core API calls such as |
From @rodrigob on March 21, 2018 20:11
The SavedModel I am trying to convert generated, amongst others; the following message:
I am wondering if tfjs-converted should not simply ignore Assert ops, and at best generate a warning rather than an error ? (I guess the same would go for Print ops)
Copied from original issue: tensorflow/tfjs-converter#42
The text was updated successfully, but these errors were encountered: