Add reference kernel support for SVDF op with all 8 bit weights and state #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njeffrie
reviewed
Sep 15, 2021
advaitjain
reviewed
Sep 20, 2021
advaitjain
changed the title
advaitjain
reviewed
Sep 20, 2021
advaitjain
previously approved these changes
Sep 20, 2021
advaitjain
previously approved these changes
Sep 20, 2021
advaitjain
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra memory usage comes from 7 OpDataSvdf structs. I only added 4 bytes to each, but with 16-byte alignment I got unlucky and added 16 bytes total to each of these allocations.
BUG=179816930