Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metadata, codegen and java lib into the new repo. #11

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

copybara-service[bot]
Copy link

Move metadata, codegen and java lib into the new repo.

@copybara-service copybara-service bot force-pushed the test_317265064 branch 14 times, most recently from f92cadf to 927a8e2 Compare July 1, 2020 01:34
@lutzroeder
Copy link

@xunkai55 why was this code removed from the TensorFlow main repository before this PR was merged.

@xunkai55
Copy link
Contributor

xunkai55 commented Jul 1, 2020

@xunkai55 why was this code removed from the TensorFlow main repository before this PR was merged.

We got some problem in code migration process. Will resolve the problem soon

@xunkai55 xunkai55 merged commit 3ce83f0 into master Jul 1, 2020
@lutzroeder
Copy link

lutzroeder commented Jul 1, 2020

Would it make sense to keep metadata_schema.fbs in the TensorFlow repo? It's not worth the extra effort tracking another repository and leaning towards removing support. Wasn't the goal to include this with the official TensorFlow Lite schema?

@xunkai55
Copy link
Contributor

xunkai55 commented Jul 1, 2020

@lutzroeder Thanks for your suggestion. May I know more about your use cases? E.g. When you use the metadata_schema.fbs, what kind of tools you also use to consume it?

It would help us better decide if we should keep a copy in main TF repo. Thanks!

@lutzroeder
Copy link

lutzroeder commented Jul 1, 2020

@lu-wang-g
Copy link
Member

@lutzroeder it is true that we do have the future vision of the merging the metadata schema with the TFLite schema, but the plan is not concrete yet. At least for now, the metadata library is an important component of the TFLite Support library, and it is released through the Support library package for each version, not through the TF/TFLite package.

Honry added a commit to Honry/tflite-support that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants