Support convert from UpperLeft, Center in BoundingBoxUtils #15
Conversation
tensorflow_lite_support/java/src/java/org/tensorflow/lite/support/image/BoundingBoxUtil.java
Outdated
Show resolved
Hide resolved
tensorflow_lite_support/java/src/java/org/tensorflow/lite/support/image/BoundingBoxUtil.java
Outdated
Show resolved
Hide resolved
| return new RectF( | ||
| left, top, right, bottom); | ||
| } else { | ||
| throw new IllegalArgumentException("BoundingBox.Type Center is not supported with CoordinateType CoordinateType.RATIO"); |
There was a problem hiding this comment.
IMHO, it looks like able to be supported - perhaps leave a TODO here if you don't want to put all in one PR.
There was a problem hiding this comment.
I will just add it here. Please confirm if with CoordinateType.RATIO, centerX = values[0] * width, centerY = values[1] * height . What will values[2], values[3] depict? (as we will be using height and width from parameters)
There was a problem hiding this comment.
@xunkai55 Thanks for reviewing, I have made other changes, please check.
There was a problem hiding this comment.
values[2] and [3] represent the relative width and height of the bounding box. So the height and width of the box should be values[2] * width, or imageWidth as I commented in another thread.
| left, top, left + w, top + h); | ||
| } else { | ||
| return new RectF( | ||
| values[0] * width, values[1] * height, width * values[2], height * values[3]); |
There was a problem hiding this comment.
For readability, I'd suggest to move "left", "top", "w", "h" out of the conditional scope, and not use value[i] directly. Argument of the function height and width maybe should be renamed to imageHeight and imageWidth to avoid confusion.
And particularly in this line, let's keep expressions in a same order, e.g. foo * imageHeight or foo * imageWidth.
There was a problem hiding this comment.
Correct expressions seem to be
values[0] * imageWidth
values[1] * imageHeight
(values[0] + values[2]) * imageWidth
(values[1] + values[3]) * imageHeight
| float w = values[2]; | ||
| float h = values[3]; | ||
|
|
||
| float left = centerX - w/2; |
There was a problem hiding this comment.
Please add spaces around operator /.
| float w = values[2]; | ||
| float h = values[3]; | ||
|
|
||
| return new RectF( |
There was a problem hiding this comment.
Nit: New line here is not needed.
| float right = centerX + w/2; | ||
| float bottom = centerX + h/2; | ||
|
|
||
| return new RectF( |
There was a problem hiding this comment.
Nit: New line is not needed.
|
Thanks a lot @xunkai55 for reviewing, I have made changes according to your suggestions. Very sorry for the delay |
|
Thank you @am15h for the contribution. The PR is merged now. |
No description provided.