Skip to content

Commit

Permalink
Update code based on reviewer comments.
Browse files Browse the repository at this point in the history
- Fix issues in pred2bq readme
- Reverted version change in setup.py
- Add abls-py test prerequisite in setup.py
  • Loading branch information
cfezequiel committed May 15, 2023
1 parent 008635f commit 20f4068
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def get_long_description():
return fp.read()


TESTS_REQUIRE = ["pytest", "pylint", "pre-commit", "isort", "yapf"]
TESTS_REQUIRE = ["pytest", "pylint", "pre-commit", "isort", "yapf", "absl-py"]

PKG_REQUIRES = get_pkg_metadata()
EXTRAS_REQUIRE = PKG_REQUIRES.copy()
Expand Down
8 changes: 5 additions & 3 deletions tfx_addons/predictions_to_bigquery/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,17 @@ import tfx_addons as tfxa
...

predictions_to_bigquery = tfxa.predictions_to_bigquery.PredictionsToBigQuery(
schema=schema_gen.outputs['schema']
inference_results=bulk_inferrer.outputs['inference_result'],
schema=schema_gen.outputs['schema'],
transform_graph=transform.outputs['transform_graph'],
bq_table_name='my_bigquery_table',
gcs_temp_dir='gs://bucket/temp-dir',
vocab_label_file='Label',
)
```

TFX pipeline examples can be found in `integration_test.py`.
Refer to `integration_test.py` for tests that demonstrates how to use the
component.

For a description of the inputs and execution parameters of the component,
refer to the `component.py` file.
Expand All @@ -77,7 +79,7 @@ See `version.py` in the top repo directory for component dependencies.

## Testing

Each Python module has a correspondin unit test file ending in `_test.py`.
Each Python module has a corresponding unit test file ending in `_test.py`.

An integration test is also available and requires use of a Google Cloud
project. Additional instructions for running the unit test can be found in `integration_test.py`.
Expand Down
2 changes: 1 addition & 1 deletion tfx_addons/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# We follow Semantic Versioning (https://semver.org/)
_MAJOR_VERSION = "0"
_MINOR_VERSION = "7"
_MINOR_VERSION = "6"
_PATCH_VERSION = "0"

# When building releases, we can update this value on the release branch to
Expand Down

0 comments on commit 20f4068

Please sign in to comment.