Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test to build file for setuptools version #12

Closed
wants to merge 8 commits into from
Closed

added test to build file for setuptools version #12

wants to merge 8 commits into from

Conversation

brandondutra
Copy link

nikhilk and others added 8 commits March 1, 2017 01:28
Fixes #3 to support model loading as it is implemented in Cloud ML.
This will make it possible to use package version programmatically when building user code packages.
Before:

    python -m tensorfx.tools.train

Now, even simpler:

    tfx train
@brandondutra
Copy link
Author

brandondutra commented Mar 12, 2017

closing this for lack of interest: instead of doing a check, documentation will just be updated to recommend the use of some virtual environment to make sure the build tools are updated.

for historical note, the check proposed in this PR was:

# Check for setuptools >30. Otherwise, tar file will not have requirements.txt
# pip list --format=columns  (list all versions)
# grep 'setuptools' (gets setuptools x.y.z)
# awk  '{print $2}' (gets x.y.z)
# awk -F. '{print $1}' (gets x)
setuptools_version=`pip list --format=columns | grep 'setuptools' | awk  '{print $2}' | awk -F. '{print $1}'`
if [[ -z $setuptools_version || $setuptools_version -lt 30 ]]; then
  echo 'setuptools version 30 or higher is required.'
  echo "This system has version ${setuptools_version}"
  echo 'First upgrade: pip install --upgrade setuptools'
  exit 1
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants