Fix partial_svd randomness when seed is not set

tensorly · Dec 22, 2020 · 0eb0942 · 0eb0942
1 parent 65d5035
commit 0eb0942
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tensorly/backend/core.py b/tensorly/backend/core.py
@@ -761,8 +761,9 @@ def partial_svd(self, matrix, n_eigenvecs=None, random_state=None, **kwargs):
             # We can perform a partial SVD
             # construct np.random.RandomState for sampling a starting vector
             if random_state is None:
-                # if random_state is not specified, do not initialize a starting vector
-                v0 = None
+                # if random_state is not specified, initilize with [-1, 1] using global numpy RNG
+                rns = np.random.mtrand._rand
+                v0 = rns.uniform(-1, 1, min_dim)
             elif isinstance(random_state, int):
                 rns = np.random.RandomState(random_state)
                 # initilize with [-1, 1] as in ARPACK

diff --git a/tensorly/contrib/sparse/backend/numpy_backend.py b/tensorly/contrib/sparse/backend/numpy_backend.py
@@ -123,8 +123,9 @@ def partial_svd(matrix, n_eigenvecs=None, random_state=None, **kwargs):
             # We can perform a partial SVD
             # construct np.random.RandomState for sampling a starting vector
             if random_state is None:
-                # if random_state is not specified, do not initialize a starting vector
-                v0 = None
+                # if random_state is not specified, initilize with [-1, 1] using global numpy RNG
+                rns = np.random.mtrand._rand
+                v0 = rns.uniform(-1, 1, min_dim)
             elif isinstance(random_state, int):
                 rns = np.random.RandomState(random_state)
                 # initilize with [-1, 1] as in ARPACK