We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modes are not considered when init is random:
init
random
tensorly/tensorly/decomposition/_tucker.py
Lines 78 to 86 in a982cf9
When init is random, do we always assume that all modes should be considered? init == svd allows to initialize along specific modes.
svd
Morever, in the following test init is svd while it should be random https://github.com/tensorly/tensorly/blob/main/tensorly/decomposition/tests/test_tucker.py#L59-L64
The text was updated successfully, but these errors were encountered:
You are absolutely right, thanks for highlighting @hello-fri-end! Would be great if you could open a small PR to fix it!
Sorry, something went wrong.
Sure, created a PR here to fix the same: #519
Fixed in #519
No branches or pull requests
Modes are not considered when
init
israndom
:tensorly/tensorly/decomposition/_tucker.py
Lines 78 to 86 in a982cf9
When
init
is random, do we always assume that all modes should be considered?init
==svd
allows to initialize along specific modes.Morever, in the following test
init
issvd
while it should berandom
https://github.com/tensorly/tensorly/blob/main/tensorly/decomposition/tests/test_tucker.py#L59-L64
The text was updated successfully, but these errors were encountered: