Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialize_tucker #519

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Conversation

hello-fri-end
Copy link
Contributor

…cker and updated the test of partial_tucker to pass init==random when testting randomstate
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #519 (4f8a945) into main (a982cf9) will decrease coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   86.78%   86.70%   -0.08%     
==========================================
  Files         118      118              
  Lines        7515     7515              
==========================================
- Hits         6522     6516       -6     
- Misses        993      999       +6     
Files Changed Coverage Δ
tensorly/decomposition/_tucker.py 87.91% <ø> (ø)
tensorly/decomposition/tests/test_tucker.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeanKossaifi
Copy link
Member

Thanks @hello-fri-end! Can you just fix the formatting and looks good to merge.

@hello-fri-end
Copy link
Contributor Author

Thanks @hello-fri-end! Can you just fix the formatting and looks good to merge.

Fixed the formatting. Thanks :)

@JeanKossaifi
Copy link
Member

Great, thanks for the fix @hello-fri-end, merging!
As a side note, I wrote a better init in TensorLy-Torch) we should probably bring it in at some point, it allows the reconstruction to have zero mean and given standard deviation - I opened #521

@JeanKossaifi JeanKossaifi merged commit 83a4c48 into tensorly:main Aug 19, 2023
9 of 10 checks passed
@hello-fri-end hello-fri-end deleted the fixInitializeTucker branch September 1, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants