nn_tucker hals class, doc, api improvements #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update doc fix indents edit doc
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 88.21% 88.19% -0.02%
==========================================
Files 103 103
Lines 5997 6021 +24
==========================================
+ Hits 5290 5310 +20
- Misses 707 711 +4
Continue to review full report at Codecov.
|
|
Great, thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the issue #342, we realized that
non_negative_tucker_halsdoesn't exist in the tensorly website. This PR addsnon_negative_tucker_halsfunction to website API, adds missingTucker_NN_HALSclass and improves the docs of _tucker file.