Constrained parafac example and improved docstrings #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve example and api docs improve the example imrove example fix improve texts
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 88.25% 88.20% -0.05%
==========================================
Files 103 103
Lines 6021 6021
==========================================
- Hits 5314 5311 -3
- Misses 707 710 +3
Continue to review full report at Codecov.
|
|
Looks great, thanks @caglayantuna and @cohenjer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
plot_guide_for_constrained_cpfile to the examples in order to explain how to use constrained parafac decomposition feature. Besides, we improve the docstring of constraints as we discussed before. We also realized a missingtl.absin normalize constraint and fix it.