Constrained cp class #390
Merged
Constrained cp class #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 88.29% 88.35% +0.06%
==========================================
Files 107 107
Lines 6238 6271 +33
==========================================
+ Hits 5508 5541 +33
Misses 730 730
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Great, thanks @caglayantuna! Can you also add it to the doc ( |
caglayantuna
force-pushed
the
Constrained_cp_Class
branch
from
fa71828
to
545c8ca
Compare
|
Done. |
|
Looks great, thank you @caglayantuna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that contrained parafac has no class in Tensorly. I know that classes are experimental for now but it could be useful for the future developments. This PR adds
ConstrainedCPclass to_constrained_cpfile with related changes in init and test.