New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trig functions and constants #398
Conversation
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 88.31% 88.58% +0.27%
==========================================
Files 107 107
Lines 6238 6238
==========================================
+ Hits 5509 5526 +17
+ Misses 729 712 -17
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Looks good to me, thanks for adding these ! |
Indeed — it doesn't appear that the issues are with this new PR code, but I'm happy to wait to merge this as the other issues work out, if you prefer (and I will see if I can figure out an easy fix for any of them!) Deep links to test failure lines:
Looks like there might be an import issue with tensorflow, working on that now! |
Yes, I'm fixing the JAX issue in the PR you mentioned and MXNet issue should be fixed whenever they switch to 2.0, we should use the nightly build until then. |
Awesome! In that case, I think this PR is ready for final code review and merging (i.e., all issues with the actual trig functions and constants are ironed out, I believe) |
Looks good to me, thanks @j6k4m8, merging! |
This fixes #395 and #394!