Permute factors api #404
Merged
Permute factors api #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 88.10% 88.46% +0.36%
==========================================
Files 107 107
Lines 6322 6321 -1
==========================================
+ Hits 5570 5592 +22
+ Misses 752 729 -23
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
caglayantuna
force-pushed
the
permute_factors_api
branch
from
84ef9d5
to
40ce733
Compare
|
Looks good, thanks @caglayantuna! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed during the previous PR, we add cp_permute_factors function to api and advertise this function with an example in gallery since we couldn't find a suitable place in the user guide. Also, I removed redundant rank computation from the function.