Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized ccxt requirement. #423

Closed
wants to merge 3 commits into from
Closed

Centralized ccxt requirement. #423

wants to merge 3 commits into from

Conversation

abstractguy
Copy link
Contributor

No description provided.

@carlogrisetti
Copy link
Collaborator

What's the rationale for porting ccxt "back" into the main requirements.txt? It shouldn't be needed at that level for the project to work properly, isn't it?
I feel it already is a dependency of something else, but it might be just my custom environment I'm getting confused about.

@abstractguy
Copy link
Contributor Author

abstractguy commented Mar 1, 2022

What's the rationale for porting ccxt "back" into the main requirements.txt? It shouldn't be needed at that level for the project to work properly, isn't it? I feel it already is a dependency of something else, but it might be just my custom environment I'm getting confused about.

If ccxt shouldn't be in the base requirements, what's stochastic doing there? Since they're both included in the code, (ccxt in tensortrade/data/cdd.py and stochastic in tensortrade/stochastic/), I thought they could be in the base requirements. Either way, both should be together.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants