Repo creation #101
Merged
Repo creation #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter which will supporess UserWarning messages if a Hangar repository does not exist at that location yet
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 91.78% 91.83% +0.05%
==========================================
Files 45 46 +1
Lines 8184 8454 +270
Branches 819 834 +15
==========================================
+ Hits 7511 7763 +252
- Misses 492 508 +16
- Partials 181 183 +2
|
rlizzo
force-pushed
the
repo-creation
branch
2 times, most recently
from
ae5f73d
to
480acbe
Compare
3 tasks
hhsecond
reviewed
Aug 5, 2019
| @@ -68,6 +89,7 @@ def __init__(self, base_path: os.PathLike, labelenv: lmdb.Environment, | |||
| commit_hash=self._commit_hash, | |||
| branchenv=self._branchenv, | |||
| refenv=self._refenv) | |||
| atexit.register(self.close) | |||
There was a problem hiding this comment.
IMO we need another function that gets called on atexit which does two things
- Printout a warning to the terminal saying what hangar did internally (closed the checkout for user) and it is not at all recommended. This is important because otherwise user would never remember to add the explicit close
self.close()
There was a problem hiding this comment.
@rlizzo Also, this raises warning if atexit has an unregistered function and the repo has been deleted before the exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required? What problem does it solve?:
Fixes issues with inconsistent warnings and adds more user control and more sane type annotations
If it fixes an open issue, please link to the issue here:
Description
Describe your changes in detail:
existsparameter added toRepository()which if set toFalsewill suppress the warning that a repo does not exist at the given path..hangarinstead of__hangaras per [BUG REPORT] New repo creation is unfriendly #93README.txtinside.hangarfolder to aid in repo identification--versionoption to CLI.Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
xin the boxes that apply:Checklist: