Initial Testcases #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
|
@hhsecond let me know when this is ready for a code review. thanks for all the work! |
Fixed many errors around managing singleton contexts, temporarily disabled doctests until we are able to configure autodoc correctly.
|
hey @hhsecond, As you'll see I pushed some changes on my end to update the tests and the test-runners. The travis-ci build is now passing on all tests (the appveyor config still needs some work, i'm not really sure what this issue with windows is right now). In general, really nice job! Definitely on our way to having decent test coverage here. I'll send in some more changes/comments when I have the next free minute, but this is a great start! |
9 tasks
|
see also #20 which we will want to merge and rebase this branch on top of. |
rlizzo
requested changes
May 1, 2019
rlizzo
approved these changes
May 2, 2019
|
I'm going to merge this so that focused test development can occur in isolated PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.