Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hdf5plugin for faster compression #146

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Oct 21, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

HDF5Plugin 2.0.0 was released which allows blosc filters for h5py on PyPi

https://github.com/silx-kit/hdf5plugin

Description

Describe your changes in detail:

Added new requirement, hdf5plugin==2.0.0

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@rlizzo rlizzo requested a review from hhsecond October 21, 2019 11:43
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #146 into master will increase coverage by 0.12%.
The diff coverage is 71.43%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   93.26%   93.38%   +0.12%     
==========================================
  Files          62       62              
  Lines       10964    10969       +5     
  Branches     1061     1061              
==========================================
+ Hits        10225    10243      +18     
+ Misses        521      508      -13     
  Partials      218      218
Impacted Files Coverage Δ
tests/test_backend_hdf5_00.py 100% <100%> (+21.13%) ⬆️
src/hangar/backends/hdf5_00.py 91.76% <60%> (-0.64%) ⬇️

@rlizzo rlizzo merged commit 14d9d50 into tensorwerk:master Oct 21, 2019
@rlizzo rlizzo deleted the hdf5plugin-requirement branch October 24, 2019 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant