-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation discussing hangar core concepts #23
Conversation
ping @hhsecond for review as well. |
docs/concepts.rst
Outdated
data management utilities developed by the High Performance Computing community | ||
over the past few decades. | ||
|
||
In a sense, the backend of Hangar servers two functions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"serves"
Thanks @elistevens, you're comments have been addressed! ping @lantiga for general comments before I proofread and merge. |
docs/concepts.rst
Outdated
arrays of particular datatypes, shapes, and access patterns), we simultaneously | ||
store different data pieces in the backend which is most suited to it. A great | ||
deal of care has been taken to optimize parameters in the backend interface | ||
which affecting performance and compression of data samples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"which affecting" review wording?
docs/concepts.rst
Outdated
property: | ||
|
||
If you ``clone`` some hangar repository, Bookeeping says that "some number | ||
of data piece exist" and they should retrieved from the server. However, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pieces"?
docs/concepts.rst
Outdated
Aka. You don't need data on disk to merge changes into it. It's an odd concept | ||
which will be explained more in depth in the future. | ||
|
||
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this up for full transparency.
Discusses core data model, problems we try to solve, and the rationale for solving them in the first place
Thanks for the detailed feedback @elistevens. All comments have been resolved and I am going to merge this now |
Discusses core data model, problems we try to solve, and the rationale
for solving them in the first place
ping @lantiga for discussion and review.