Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata testcases #27

Merged
merged 3 commits into from May 8, 2019
Merged

Metadata testcases #27

merged 3 commits into from May 8, 2019

Conversation

hhsecond
Copy link
Member

@hhsecond hhsecond commented May 2, 2019

Description

Basic test cases for Metadata

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hhsecond hhsecond added the WIP Don't merge; Work in Progress label May 2, 2019
@hhsecond hhsecond changed the title Metadata tests Metadata testcases May 2, 2019
@hhsecond hhsecond requested a review from rlizzo May 2, 2019 21:25
Copy link
Member

@rlizzo rlizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few bug's which need fixing before we merge, but in general these are a good start.

Let's also add a few tests which stress the amount of text which can be in a value, and the length of a metadata key name as well. I have a sinking suspicion that the default lmdb key length limit (511 bytes) will raise errors which may not propagate clearly through to user space if they are exceeded.

Nice work!

tests/test_metadata.py Show resolved Hide resolved
tests/test_metadata.py Show resolved Hide resolved
tests/test_metadata.py Show resolved Hide resolved
tests/test_metadata.py Outdated Show resolved Hide resolved
@hhsecond
Copy link
Member Author

hhsecond commented May 7, 2019

Let's also add a few tests which stress the amount of text which can be in a value, and the length of a metadata key name as well. I have a sinking suspicion that the default lmdb key length limit (511 bytes) will raise errors which may not propagate clearly through to user space if they are exceeded.

Will add this to stress test cases

@rlizzo rlizzo added this to the v0.1.0 Release milestone May 7, 2019
@hhsecond
Copy link
Member Author

hhsecond commented May 8, 2019

@rlizzo Verified, rebased and pushed. This can be merged if you are good. The pending TODOs can be tracked through corresponding issues. Keeping this open till those are fixed might make this stale

@hhsecond hhsecond removed the WIP Don't merge; Work in Progress label May 8, 2019
@rlizzo
Copy link
Member

rlizzo commented May 8, 2019

Looks good. Let's merge!

@rlizzo rlizzo merged commit 73f9bdd into tensorwerk:master May 8, 2019
@hhsecond hhsecond deleted the metadata_tests branch May 8, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants