New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multithread / multiprocess safe dataset reads #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlizzo
added
enhancement
New feature or request
WIP
Don't merge; Work in Progress
labels
Jul 7, 2019
…thods for read checkouts. works with the batch get implementation, but needs review
rlizzo
force-pushed
the
enable-multiprocess-reads
branch
from
July 8, 2019 17:00
9461637
to
d5426b4
Compare
hhsecond
reviewed
Jul 11, 2019
hhsecond
reviewed
Jul 11, 2019
rlizzo
changed the title
WIP: multithread / multiprocess safe dataset reads
multithread / multiprocess safe dataset reads
Jul 11, 2019
Merging now! |
Thanks for the review @hhsecond! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required? What problem does it solve?:
This is the initial work on making hangar reads thread/process safe. The
batch_get
function is the preffered method for user interaction.If it fixes an open issue, please link to the issue here:
Addresses some of the requirements to enable: #13
Description
Describe your changes in detail:
DatasetDataReader
class no longer contains references to lmdb environments. This change was made as it cannot be serialized and sent across processes.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist: