Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Refactoring moreh_layernorm #9336

Closed
hschoi4448 opened this issue Jun 10, 2024 · 0 comments
Closed

[Feature Request] Refactoring moreh_layernorm #9336

hschoi4448 opened this issue Jun 10, 2024 · 0 comments
Assignees
@hschoi4448
Labels
feature-request External feature request moreh moreh contribution

Comments

@hschoi4448
Copy link
Contributor

hschoi4448 commented Jun 10, 2024 •
edited
Loading

refactoring moreh_layernorm

  • add fp32_dest_acc_en support
  • support non 4d tensor
  • support optional output tensor
@hschoi4448 hschoi4448 added feature-request External feature request moreh moreh contribution labels Jun 10, 2024
@hschoi4448 hschoi4448 self-assigned this Jun 10, 2024
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change from optional reference_wrapper to optional
f099e44
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change from acquire_dst to tile_regs_acquires api
6f807cd
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: apply fp32_dest_acc_en to moreh_layrnorm and backward
636bea9
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: support non 4d input for moreh_layernorm forward
bd87be6
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: support non4d for moreh_layrnorm_backward
5339ecb
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: create helper functions for moreh_layerrnorm
d19d864
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: update moreh_common copy_tile_init_with_dt function add transpose
3fe8d0d
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change the output tensor to an optional output
dd883be
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: minor code update and code clean up
4d832a9
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: remove unused function
e1336cc
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: support non 4d for moreh_layernorm backward
bf948e6
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: fix moreh_layernorm callback
5449585
@hschoi4448 hschoi4448 mentioned this issue Jun 24, 2024
Merged
3 tasks
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change helper function variable name
0141523
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change from optional reference_wrapper to optional
2001d1f
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change from acquire_dst to tile_regs_acquires api
2ebeda5
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: apply fp32_dest_acc_en to moreh_layrnorm and backward
c0fb8a1
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: support non 4d input for moreh_layernorm forward
9200e7b
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: support non4d for moreh_layrnorm_backward
862ad7c
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: create helper functions for moreh_layerrnorm
93171ee
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: update moreh_common copy_tile_init_with_dt function add transpose
385ceea
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change the output tensor to an optional output
42dbdda
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: minor code update and code clean up
a2d5d5f
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: remove unused function
0d648ef
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: support non 4d for moreh_layernorm backward
43ba7ad
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: fix moreh_layernorm callback
3187254
hschoi4448 added a commit that referenced this issue Jun 24, 2024
@hschoi4448
#9336: change helper function variable name
61d6e3f
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: minor code update and code clean up
89cceca
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: remove unused function
fb7afed
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: support non 4d for moreh_layernorm backward
d47c77c
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: fix moreh_layernorm callback
23e67cf
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: change helper function variable name
8c2835c
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: skip for Grayskull, due to copy_tile hang
d25b8b1
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: delete debug tests
5f2087a
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: support case where mean and rstd are not created
45f3a72
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: fix TT_FATAL comment and add TT_FATAL to compute_output_shapes
ef9ed9a
hschoi4448 added a commit that referenced this issue Jul 4, 2024
@hschoi4448
#9336: change output_mem_config to memory_config
7982b66
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: change from optional reference_wrapper to optional
2f94226
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: change from acquire_dst to tile_regs_acquires api
b3d63b1
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: apply fp32_dest_acc_en to moreh_layrnorm and backward
3f55086
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: support non 4d input for moreh_layernorm forward
e7ab368
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: support non4d for moreh_layrnorm_backward
6c7eb76
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: create helper functions for moreh_layerrnorm
1abd38a
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: update moreh_common copy_tile_init_with_dt function add transpose
30107a3
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: change the output tensor to an optional output
01866aa
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: minor code update and code clean up
d042537
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: remove unused function
db8e289
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: support non 4d for moreh_layernorm backward
a99a420
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: fix moreh_layernorm callback
b57dc3f
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: change helper function variable name
554f249
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: skip for Grayskull, due to copy_tile hang
f033d37
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: delete debug tests
c5429dc
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: support case where mean and rstd are not created
0dd380b
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: fix TT_FATAL comment and add TT_FATAL to compute_output_shapes
11fe258
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: change output_mem_config to memory_config
efc633d
hschoi4448 added a commit that referenced this issue Jul 5, 2024
@hschoi4448
#9336: Refactoring moreh layernorm (#9636)
c52e153 
The current `moreh_layernorm` only accepts 4D tensors as input. To meet this restriction, the mean and rstd tensors are stored inefficiently, with only one valid data point per tile.
The current implementation does not support optional outputs and the fp32_dest_acc_en feature.

Refactoring moreh_layernorm
- add fp32_dest_acc_en support
- support non 4d tensor
- support optional output tensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hschoi4448 hschoi4448

Labels
feature-request External feature request moreh moreh contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hschoi4448