Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch2.0_ttnn support master issue #9546

Open
3 of 4 tasks
tt-rkim opened this issue Jun 19, 2024 · 5 comments
Open
3 of 4 tasks

pytorch2.0_ttnn support master issue #9546

tt-rkim opened this issue Jun 19, 2024 · 5 comments
Assignees
Labels
infra-ci infrastructure and/or CI changes P1_critical ttnn

Comments

@tt-rkim
Copy link
Collaborator

tt-rkim commented Jun 19, 2024

Introduction

We are putting all relevant issues + action items for supporting https://github.com/tenstorrent-metal/pytorch2.0_ttnn/ and related infrastructure issues here.

cc: @ayerofieiev-tt @TT-billteng @ttmchiou

  • ensure everyone who currently has access, has access after the move too (need to open OSPO ticket w/ John Hawley, @ayerofieiev-tt to finalize list of people)
  • move the actual repo (need to open OSPO ticket w/ John Hawley)
  • Create starter CI VM @ttmchiou
  • Finalize list of all system and software requirements for CI VM @ayerofieiev-tt
@tt-rkim tt-rkim added infra-ci infrastructure and/or CI changes ttnn P1_critical labels Jun 19, 2024
@tt-rkim
Copy link
Collaborator Author

tt-rkim commented Jun 19, 2024

From @kevinwuTT :

  • On a completely fresh python virtual environment, I can successfully install ttnn from the github direct whl link and other requirements from pytorch2.0_ttnn requirements.txt. I can import ttnn successfully from here.
    • However, the tests do depend on tests.ttnn.utils_for_testing module which isn't in the release whl from github. I'm not sure if I can remove this dependency since many of the unit tests from tt-metal/ttnn also uses the functions from that module.
  • I will include a dev version of requirements.txt which won't install the whl and rely on the user creating the python virtual env with ./create_venv.sh from tt-metal. That creates an egg link to the ttnn source directory which makes development easier.
  • I can push the changes to requirements.txt to main, but I am still not sure how to address the issue with the tests module from the first point.

@ayerofieiev-tt
Copy link
Member

tests.ttnn.utils_for_testing is currently only used for a pcc check.
We agreed that @kevinwuTT will remove it.

@ayerofieiev-tt
Copy link
Member

@ttmchiou @tt-rkim

Screenshot 2024-06-19 at 8 11 21 PM

@ttmchiou
Copy link
Contributor

tt-metal-pytorch-vm-1 CI VM added to repo with sample GH workflow provided
tenstorrent/pytorch2.0_ttnn#4
https://github.com/tenstorrent-metal/pytorch2.0_ttnn/actions
Will need follow-up from @ayerofieiev-tt for list of deps needed for installation.

@ttmchiou
Copy link
Contributor

@tt-rkim
@ayerofieiev-tt has finished shifting the pytorch repo to the TT org and current members are ported over to have same access.
Would be prudent to start planning VM consolidation soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci infrastructure and/or CI changes P1_critical ttnn
Projects
None yet
Development

No branches or pull requests

3 participants