Merge pull request #61 from StrandedKitty/fix/texture-disposal

Dispose tile textures
tentone · Jul 10, 2023 · 5b4c9d3 · 5b4c9d3
2 parents 5a0f91f + 5e73677
commit 5b4c9d3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/source/nodes/MapHeightNodeShader.ts b/source/nodes/MapHeightNodeShader.ts
@@ -178,4 +178,16 @@ export class MapHeightNodeShader extends MapHeightNode
 			this.geometry = MapHeightNodeShader.geometry;
 		}
 	}
+
+	public dispose(): void
+	{
+		super.dispose();
+
+		// @ts-ignore
+		if (this.material.userData.heightMap.value && this.material.userData.heightMap.value !== MapHeightNodeShader.defaultHeightTexture)
+		{
+			// @ts-ignore
+			this.material.userData.heightMap.value.dispose();
+		}
+	}
 }
diff --git a/source/nodes/MapNode.ts b/source/nodes/MapNode.ts
@@ -351,6 +351,13 @@ export abstract class MapNode extends Mesh
 		{
 			const material = self.material as Material;
 			material.dispose();
+
+			// @ts-ignore
+			if (material.map && material.map !== MapNode.defaultTexture)
+			{
+				// @ts-ignore
+				material.map.dispose();
+			}
 		}
 		catch (e) {}