Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript migration #12

Merged
merged 3 commits into from
May 14, 2021
Merged

Conversation

farfromrefug
Copy link
Contributor

  • changes:
    • moved all classes to TS
    • for now kept all comments doc as they are.
  • build i saw the action failed so it should work. Will see what i can do
  • about the code style. It is actually an issue if trying to keep the way you were formatting. I was trying to use eslint paired with prettier. The reason for that is to be able to lint both syntax and format errors through eslint. However prettier does not allow some of your code styling like brackets on new lines or such things. There is no easy way around it.
    If you dont like it we can remove prettier even though it is really nice to develop with.

For the docs i wont have much time to do it in the weeks to come. If you want to have a go at it you have right permission on that PR.

# Conflicts:
#	.eslintrc.js
#	build/geo-three.js
#	package.json
#	rollup.dev.js
#	source/Main.js
#	source/MapView.ts
#	source/lod/LODFrustum.js
#	source/lod/LODRaycast.js
#	source/nodes/MapHeightNode.ts
#	source/nodes/MapHeightNodeShader.ts
#	source/nodes/MapNode.ts
#	source/nodes/MapPlaneNode.ts
#	source/nodes/MapSphereNode.ts
@tentone tentone merged commit e50487b into tentone:development May 14, 2021
@tentone
Copy link
Owner

tentone commented May 14, 2021

Thanks a lot! Merged i will start fixing some of the things.

@farfromrefug farfromrefug deleted the typescript branch May 14, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants