Fix XSV format printing the header once for each batch

tenzir · May 8, 2024 · 28ae64d · 28ae64d
1 parent c810f07
commit 28ae64d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/libtenzir/builtins/formats/xsv.cpp b/libtenzir/builtins/formats/xsv.cpp
@@ -453,8 +453,9 @@ class xsv_printer final : public plugin_printer {
   instantiate([[maybe_unused]] type input_schema, operator_control_plane&) const
     -> caf::expected<std::unique_ptr<printer_instance>> override {
     auto metadata = chunk_metadata{.content_type = content_type()};
-    return printer_instance::make([meta = std::move(metadata), args = args_](
-                                    table_slice slice) -> generator<chunk_ptr> {
+    return printer_instance::make([meta = std::move(metadata), args = args_,
+                                   first = true](table_slice slice) mutable
+                                  -> generator<chunk_ptr> {
       if (slice.rows() == 0) {
         co_yield {};
         co_return;
@@ -468,7 +469,6 @@ class xsv_printer final : public plugin_printer {
       auto input_type = caf::get<record_type>(input_schema);
       auto array
         = to_record_batch(resolved_slice)->ToStructArray().ValueOrDie();
-      auto first = true;
       for (const auto& row : values(input_type, *array)) {
         TENZIR_ASSERT(row);
         if (first && not args.no_header) {

diff --git a/tenzir/integration/data/reference/pipelines_local/test_xsv_format/step_04.ref b/tenzir/integration/data/reference/pipelines_local/test_xsv_format/step_04.ref
@@ -1,4 +1,3 @@
 foo
 1
-foo
 2