Enable loading of concepts from disk #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
force-pushed
the
tdhtf/ch1682/load-concepts
branch
from
f6d5c9e
to
759dc50
Compare
mavam
requested changes
Oct 21, 2020
tobim
force-pushed
the
tdhtf/ch1682/load-concepts
branch
5 times, most recently
from
1decade
to
fe174ca
Compare
mavam
requested changes
Oct 22, 2020
| // Local commands need access to the node actor. | ||
| // This is a side-channel to communicate the self pointer into the spawn- and | ||
| // send-command functions, whose interfaces are constrained by the command | ||
| // factory. |
There was a problem hiding this comment.
Do you see a way to get rid of this wart at some point in the future?
There was a problem hiding this comment.
In retrospect, the invocation based interface to the node turned out as less elegant that we'd hoped. I would like to replace it with something more type-safe at some point, but that will require one or two design sessions first.
|
I tested the feature with a custom URL concept that pulls data from Zeek and Suricata logs: - concept:
name: url
fields:
- zeek.http.uri
- suricata.http.http.urlNice work! Just cosmetic stuff to be fixed. |
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
tobim
force-pushed
the
tdhtf/ch1682/load-concepts
branch
from
e5f48a3
to
aff6f17
Compare
mavam
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: