Age rotation for old data #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
story/ch19925/age-rotation
branch
5 times, most recently
from
aee289c
to
283f03e
Compare
lava
force-pushed
the
story/ch19925/age-rotation
branch
3 times, most recently
from
c6c732c
to
2b83441
Compare
mavam
requested changes
Oct 23, 2020
lava
force-pushed
the
story/ch19925/age-rotation
branch
2 times, most recently
from
f7866f3
to
7a9bbb1
Compare
9 tasks
lava
force-pushed
the
story/ch19925/age-rotation
branch
from
7a9bbb1
to
d7b562c
Compare
dominiklohmann
requested changes
Oct 27, 2020
There was a problem hiding this comment.
Some comments, mostly on log message wording.
This needs two changelog entries: A change for the archive options, and an experimental feature for the disk monitor. Please reflect all new and changed options in the example configuration.
The integration test should be disabled on macOS as discussed via Slack. .DS_Store files don't play well with how we're currently calculating the directory size and how the test is currently implemented.
Add a method to compute recursive directory size. Also make some members of `vast::directory` const in order to support usage of the class in a const context.
lava
force-pushed
the
story/ch19925/age-rotation
branch
2 times, most recently
from
e1ea50b
to
c68d6df
Compare
mavam
requested changes
Oct 27, 2020
I've verified this to work locally on macOS. It's fine for an experimental feature, I think. |
lava
force-pushed
the
story/ch19925/age-rotation
branch
from
c68d6df
to
2ef5383
Compare
dominiklohmann
requested changes
Oct 27, 2020
Fix a double-free bug when copying a vast::directory, that was caused by a Rule-of-Three violation; i.e. when copying a directory the contained `DIR*` was simply copied and then closed multiple time in the destructor.
lava
force-pushed
the
story/ch19925/age-rotation
branch
from
2ef5383
to
af144d0
Compare
Add a new 'disk_monitor' actor that periodically monitors disk usage of the vast database directory and triggers removal of old partitions.
lava
force-pushed
the
story/ch19925/age-rotation
branch
from
af144d0
to
553a664
Compare
mavam
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review instructions: Each commit can be reviewed individually, although 90% of the changes are in the last commit anyways.