Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a hang when trying to process an invalid query #1189

Merged
merged 2 commits into from Nov 23, 2020
Merged

Fix a hang when trying to process an invalid query #1189

merged 2 commits into from Nov 23, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Nov 20, 2020

馃摂 Description

We (I) forgot to deliver the response promise in one place in the spawn handler in the node.

馃摑 Checklist

  • All user-facing changes have changelog entries.

@tobim tobim added the bug Incorrect behavior label Nov 20, 2020
@tobim tobim requested review from mavam and a team November 20, 2020 14:59
@dominiklohmann
Copy link
Member

Nice catch! How did you find this one?

mavam
mavam approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by verifying that vast export json 'ff02:2' no longer hangs but returns a parse error instead.

@mavam
Copy link
Member

mavam commented Nov 20, 2020

@tobim could you add an integration test that a failing query terminates?

@tobim tobim merged commit 4c36988 into master Nov 23, 2020
@tobim tobim deleted the story/ch20665/invalid-query-hangs branch November 23, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
3 participants
@tobim @dominiklohmann @mavam