Switch to spdlog as logging framwork #1223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dominiklohmann
changed the title
tobim
reviewed
Dec 10, 2020
dominiklohmann
force-pushed
the
epic/spdlog
branch
from
173d242
to
1b271fb
Compare
|
oh, nice , thank you @dominiklohmann for adding that to the build! After our matrix chat this morning I was just going to start adding this and now I find out it is already done. What an awesome team this is! |
lava
force-pushed
the
epic/spdlog
branch
3 times, most recently
from
4f4c95e
to
86f876b
Compare
lava
changed the title
lava
force-pushed
the
epic/spdlog
branch
5 times, most recently
from
6cbaf18
to
140a3e4
Compare
* Add spdlog to the build system * Adopt log file config to be under vast * Adopt log init system * Addopt logging macros to use spdlog * Add required helper functions * Add required ftm formatter spezialisations * Adopt exampel yaml
This will be removed from the branch after rewriting is done.
|
I'm closing this an recreating a new PR so @dominiklohmann is also able to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
This PR serves as a merge base for @a4z's work on integrating spdlog with VAST.
All CI changes have to take place in this PR, because GitHub does not use Workflow changes from forks.
馃摑 Checklist
馃幆 Review Instructions
Look at the commits to understand the overall structure of the rewrite.
Then,