Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading and dumping of composed concepts #1236

Merged
merged 2 commits into from Dec 15, 2020
Merged

Fix loading and dumping of composed concepts #1236

merged 2 commits into from Dec 15, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Dec 15, 2020

馃摂 Description

What the title says.

馃摑 Checklist

  • All user-facing changes have changelog entries.

@tobim tobim requested a review from a team December 15, 2020 20:50
@tobim tobim added the bug Incorrect behavior label Dec 15, 2020
dominiklohmann
dominiklohmann approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial fix, obvious oversight (in hindsight). Thanks! 馃檹

@mavam
Copy link
Member

mavam commented Dec 15, 2020

Really nice to see this fixup making it in right before the release, @tobim. 馃挭

@tobim tobim merged commit 81be3ee into master Dec 15, 2020
@tobim tobim deleted the story/ch21218/fix-composed-concepts branch December 15, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
3 participants
@tobim @mavam @dominiklohmann