Adapt build config to work with simdjson 0.8.0 #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a stupid bug in simdjson 0.8.0: it does not export a `simdjson-config.cmake` file, so `find_package(simdjson)` can't work. Instead, it exports the file as `simdjson-targets.cmake`, which usually exists for other purpsoes. ¯\_(ツ)_/¯
dominiklohmann
force-pushed
the
topic/simdjson-0.8.0-cmake-workaround
branch
from
3ab98b7 to
03c9e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
There's a stupid bug in simdjson 0.8.0: it does not export a
simdjson-config.cmakefile, sofind_package(simdjson)can't work. Instead, it exports the file assimdjson-targets.cmake, which usually exists for other purpsoes. ¯\_(ツ)_/¯📝 Checklist
🎯 Review Instructions
Verify that it works with simdjson 0.8.0 while keeping compatibility with older versions.