Fix usage of simdjson::simdjson_result<T> #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/simdjson-0.8.0-result-usage
branch
from
d7ebb77 to
8e83870
Compare
Before simdjson 0.8.0, `simdjson::simdjson_result<T>` inherited from `std::pair<T, Error>` publicly, which allowed us to use it in a possibly unintended way. The type no longer decomposes into structured bindings, so we now use `.error()` and `.value()` respectively where appropriate.
dominiklohmann
force-pushed
the
topic/simdjson-0.8.0-result-usage
branch
from
8e83870 to
44e7807
Compare
tobim
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Before simdjson 0.8.0,
simdjson::simdjson_result<T>inherited fromstd::pair<T, Error>publicly, which allowed us to use it in a possibly unintended way. The type no longer decomposes into structured bindings, so we now use.error()and.value()respectively where appropriate.📝 Checklist
🎯 Review Instructions
File-by-file.