-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nested records in the Arrow Builder #1429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good.
I would like to see a brief unit and/or integration test before greenlighting this PR.
Working on that currently. I'm trying to look into the feasibility of adding the missing conversions to the JSON reader so an integration test becomes possible. Then the second sentence from the changelog entry becomes irrelevant as well. |
364603c
to
a6986de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the second baseline empty? Shouldn't it return the ingested data?
Since we're not querying from the nested record, I thought this would work.
Edit: Fixed. |
Co-authored-by: tobim <tobim@fastmail.fm>
c10eae0
to
05ad4bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. This is perfect prep for the upcoming nested lists change.
I didn't test this locally but verified the integration test baseline matches my expectation.
📔 Description
This adds support for records to the Arrow table slice builder.
📝 Checklist
🎯 Review Instructions
File-by-file.