-
-
Notifications
You must be signed in to change notification settings - Fork 95
Support toggling static/dynamic plugin builds #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
334998d
to
e77a717
Compare
fd1c10e
to
bb25c4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer-reviewed with @tobim.
1c05636
to
acec80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. Verified that type id clashes of static plugins result in a readable linker error.
acec80e
to
de467b7
Compare
I only rebased to fix the merge conflict in the CHANGELOG entry after approval. |
📔 Description
This PR enables static plugin builds.
📝 Checklist
🎯 Review Instructions
Commit-by-commit. I suggest we peer-review this in a call because there are some things in here whose need may not be entirely obvious.
This can already be reviewed before it's out of draft mode—the first commit contains the enabling CMake and plugin framework changes. Later commits simplify the plugin CMake.Ready for review.