Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support toggling static/dynamic plugin builds #1445

Merged
merged 11 commits into from Mar 15, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Mar 12, 2021

馃摂 Description

This PR enables static plugin builds.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

Commit-by-commit. I suggest we peer-review this in a call because there are some things in here whose need may not be entirely obvious.

This can already be reviewed before it's out of draft mode鈥攖he first commit contains the enabling CMake and plugin framework changes. Later commits simplify the plugin CMake. Ready for review.

@dominiklohmann dominiklohmann added the feature New functionality label Mar 12, 2021
@dominiklohmann dominiklohmann requested a review from a team March 12, 2021 15:35
@dominiklohmann dominiklohmann force-pushed the story/ch21463/static-plugins branch 9 times, most recently from 334998d to e77a717 Compare March 14, 2021 20:05
@dominiklohmann dominiklohmann marked this pull request as ready for review March 15, 2021 13:28
@dominiklohmann dominiklohmann force-pushed the story/ch21463/static-plugins branch 3 times, most recently from fd1c10e to bb25c4a Compare March 15, 2021 13:55
Copy link
Member Author

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer-reviewed with @tobim.

vast/CMakeLists.txt Show resolved Hide resolved
vast/CMakeLists.txt Show resolved Hide resolved
cmake/VASTRegisterPlugin.cmake Show resolved Hide resolved
libvast/src/plugin.cpp Outdated Show resolved Hide resolved
libvast/src/plugin.cpp Show resolved Hide resolved
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Verified that type id clashes of static plugins result in a readable linker error.

@dominiklohmann
Copy link
Member Author

I only rebased to fix the merge conflict in the CHANGELOG entry after approval.

@dominiklohmann dominiklohmann merged commit d82b9a7 into master Mar 15, 2021
@dominiklohmann dominiklohmann deleted the story/ch21463/static-plugins branch March 15, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
2 participants